Fix SharedFuture from async_send_request never becomes valid#2044
Merged
fujitatomoya merged 1 commit intoros2:rollingfrom Dec 2, 2022
llapx:topic-2039
Merged
Fix SharedFuture from async_send_request never becomes valid#2044fujitatomoya merged 1 commit intoros2:rollingfrom llapx:topic-2039
fujitatomoya merged 1 commit intoros2:rollingfrom
llapx:topic-2039
Conversation
Signed-off-by: Lei Liu <Lei.Liu.AP@sony.com>
Contributor
Author
|
It seems Jenkins broken: Can anybody fix it? |
Contributor
With those sorts of errors, Jenkins will automatically re-run it, and it did. The latest one is failing because test_time_source failed. That probably bears looking into. |
Collaborator
|
@iuhilnehc-ynos can you run CI for this? |
Collaborator
|
CI:
|
Collaborator
|
@iuhilnehc-ynos can you review this? i need another review before merge. |
iuhilnehc-ynos
approved these changes
Dec 2, 2022
Contributor
|
@fujitatomoya Should this be backported? |
Collaborator
|
@Mergifyio backport to humble |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 3, 2023
Signed-off-by: Lei Liu <Lei.Liu.AP@sony.com> (cherry picked from commit 66b1944)
jefferyyjhsu
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
Jan 3, 2023
Signed-off-by: Lei Liu <Lei.Liu.AP@sony.com>
fujitatomoya
pushed a commit
that referenced
this pull request
Jan 6, 2023
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
Apr 29, 2023
Signed-off-by: Lei Liu <Lei.Liu.AP@sony.com>
tkimura4
pushed a commit
to tier4/rclcpp
that referenced
this pull request
Aug 29, 2023
tkimura4
added a commit
to tier4/rclcpp
that referenced
this pull request
Aug 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lei Liu Lei.Liu.AP@sony.com