[foxy backport] Guard against integer overflow in duration conversion (#1584)#1761
Merged
jacobperron merged 2 commits intofoxyfrom Sep 1, 2021
Merged
[foxy backport] Guard against integer overflow in duration conversion (#1584)#1761jacobperron merged 2 commits intofoxyfrom
jacobperron merged 2 commits intofoxyfrom
Conversation
Guard against overflow when converting from rclcpp::Duration to builtin_interfaces::msg::Duration, which is a unsigned to signed conversion. Use non-std int types for consistency Handle large negative values Signed-off-by: Jacob Perron <jacob@openrobotics.org>
ivanpauno
approved these changes
Aug 31, 2021
Member
Author
|
I had to update the test due to an API missing in Foxy (22a4c6d). |
Member
Author
|
I meant to run CI before merging 🤦♂️
edit: warnings are unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #1584 to Foxy.