[foxy backport] Remove rmw-dependent unit-test checks (#1293)#1377
Merged
[foxy backport] Remove rmw-dependent unit-test checks (#1293)#1377
Conversation
* Remove rmw-dependent unit-test checks Signed-off-by: Stephen Brawner <brawner@gmail.com> * Address feedback Signed-off-by: Stephen Brawner <brawner@gmail.com> * PR Fixup Signed-off-by: Stephen Brawner <brawner@gmail.com>
Contributor
Author
|
Standard foxy build
|
Contributor
Author
|
cyclonedds only
|
jacobperron
approved these changes
Oct 5, 2020
Member
|
@ros-pull-request-builder retest this please |
Contributor
Author
|
This is all green except for test_lifecycle_service_client on MacOS, which encountered a race condition unrelated to this change (since this PR just affects |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stephen Brawner brawner@gmail.com
Signed-off-by: Stephen Brawner brawner@gmail.com
Signed-off-by: Stephen Brawner brawner@gmail.com