added documentation about number_of_handles in all examples.#341
Merged
JanStaschulat merged 3 commits intomasterfrom Mar 10, 2023
Merged
added documentation about number_of_handles in all examples.#341JanStaschulat merged 3 commits intomasterfrom
JanStaschulat merged 3 commits intomasterfrom
Conversation
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
Codecov Report
@@ Coverage Diff @@
## master #341 +/- ##
==========================================
- Coverage 69.20% 69.13% -0.08%
==========================================
Files 16 16
Lines 2715 2715
Branches 765 765
==========================================
- Hits 1879 1877 -2
- Misses 450 451 +1
- Partials 386 387 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
Contributor
Author
|
@mergify backport humble foxy |
Contributor
✅ Backports have been createdDetails
|
Contributor
Author
|
@pablogs9 could you have a look? |
mergify bot
pushed a commit
that referenced
this pull request
Mar 10, 2023
* added documentation about number_of_handles in all examples. Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> * aligned prepare() and spin() in all functions Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> * removed 'prepare' functions - to make it easier for beginners. Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> --------- Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> (cherry picked from commit 810afe1)
mergify bot
pushed a commit
that referenced
this pull request
Mar 10, 2023
* added documentation about number_of_handles in all examples. Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> * aligned prepare() and spin() in all functions Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> * removed 'prepare' functions - to make it easier for beginners. Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> --------- Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> (cherry picked from commit 810afe1) # Conflicts: # rclc_examples/src/example_action_client.c # rclc_examples/src/example_action_server.c # rclc_examples/src/example_lifecycle_node.c # rclc_examples/src/example_pingpong.cpp
This was referenced Mar 10, 2023
JanStaschulat
added a commit
that referenced
this pull request
Mar 22, 2023
…342) * added documentation about number_of_handles in all examples. Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> * aligned prepare() and spin() in all functions Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> * removed 'prepare' functions - to make it easier for beginners. Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> --------- Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> (cherry picked from commit 810afe1) Co-authored-by: Jan Staschulat <jan.staschulat@de.bosch.com>
JanStaschulat
added a commit
that referenced
this pull request
Mar 31, 2023
…#341) (#343) * added documentation about number_of_handles in all examples. (#341) * added documentation about number_of_handles in all examples. Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> * aligned prepare() and spin() in all functions Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> * removed 'prepare' functions - to make it easier for beginners. Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> --------- Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> (cherry picked from commit 810afe1) # Conflicts: # rclc_examples/src/example_action_client.c # rclc_examples/src/example_action_server.c # rclc_examples/src/example_lifecycle_node.c # rclc_examples/src/example_pingpong.cpp * resolved merge conflicts Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> --------- Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> Co-authored-by: Jan Staschulat <jan.staschulat@de.bosch.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rclc_executor_prepare()function in basic examples (as it is optional)