Skip to content

Rename *Result messages#3

Merged
esteve merged 1 commit intomasterfrom
result-messages
May 4, 2015
Merged

Rename *Result messages#3
esteve merged 1 commit intomasterfrom
result-messages

Conversation

@esteve
Copy link
Copy Markdown
Member

@esteve esteve commented May 4, 2015

…esult and SetParametersResult respectively
@esteve esteve added the in progress Actively being worked on (Kanban column) label May 4, 2015
@dirk-thomas
Copy link
Copy Markdown
Member

Should the SetParametersResult SetParametersResult be names singular (SetParameterResult) since it only describes the result of a single set parameter? The service then uses a list of these.

@wjwwood
Copy link
Copy Markdown
Member

wjwwood commented May 4, 2015

It depends on how you interpret it, because SetParametersResult should read as "a Result of SetParameters", but if you change it to SetParameterResult then it would be "a Result of SetParameter", and SetParameter is not a service that exists. However, you could consider SetParameterResult to me "a Result of trying to set a parameter", where SetParameter is not a proper thing, but a reference to an attempted action.

I'd vote to leave it as is, because one Service uses a list of them, but the SetParametersAtomically uses only one, yet it describes setting multiple services, not just one.

@dirk-thomas
Copy link
Copy Markdown
Member

My interpretation was "the result of setting a parameter". I found it unnatural that the "result for set parameters" contains only the result of setting a single parameter.

@tfoote
Copy link
Copy Markdown
Contributor

tfoote commented May 4, 2015

Without the full phrase it's going to be slightly ambiguous anyway. I don't think there's a "correct" solution.

+1

esteve added a commit that referenced this pull request May 4, 2015
@esteve esteve merged commit 9c50467 into master May 4, 2015
@esteve esteve deleted the result-messages branch May 4, 2015 20:42
@esteve esteve self-assigned this May 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in progress Actively being worked on (Kanban column)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants