Skip to content

move "getenv" function to rmw for more reuse#97

Closed
wjwwood wants to merge 1 commit intomasterfrom
configure_fastrtps_ttl
Closed

move "getenv" function to rmw for more reuse#97
wjwwood wants to merge 1 commit intomasterfrom
configure_fastrtps_ttl

Conversation

@wjwwood
Copy link
Copy Markdown
Member

@wjwwood wjwwood commented Dec 13, 2016 •
edited by mikaelarguedas
Loading

follow up of ros2/rmw_fastrtps#79

Connects to ros2/rcutils#30

@wjwwood wjwwood added the in progress Actively being worked on (Kanban column) label Dec 13, 2016
@wjwwood wjwwood force-pushed the configure_fastrtps_ttl branch from e644f8c to cf53093 Compare December 14, 2016 04:12
@wjwwood wjwwood mentioned this pull request Dec 14, 2016
Closed
@mikaelarguedas
Copy link
Copy Markdown
Member

mikaelarguedas commented Apr 17, 2017

@wjwwood

@wjwwood
Copy link
Copy Markdown
Member Author

wjwwood commented Apr 17, 2017

I will refactor this pr to use c_utilities once we finish the rename of that package.

@mikaelarguedas mikaelarguedas added ready Work is about to start (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Apr 26, 2017
@mikaelarguedas mikaelarguedas removed the ready Work is about to start (Kanban column) label May 24, 2017
@mikaelarguedas mikaelarguedas mentioned this pull request Jun 13, 2017
Closed
@mikaelarguedas mikaelarguedas mentioned this pull request Jun 22, 2017
Closed
@clalancette
Copy link
Copy Markdown
Contributor

clalancette commented Aug 4, 2017

This one is blocked essentially on ros2/rcutils#30 , so we'll wait on that outcome of that before moving on this. I'll add the "question" tag for now, though it might be more appropriate to create a new "blocked" tag instead.

@clalancette clalancette added the question Further information is requested label Aug 4, 2017
@mikaelarguedas
Copy link
Copy Markdown
Member

mikaelarguedas commented Aug 4, 2017 •
edited
Loading

I don't think that waffle handles multiple "Connects to" keywords properly because I dont think there is a good way to know to which one it should be connected. You can refer to the first issue but connect to the open one it depends on. If possible, update the label given that this issue is not a question

@clalancette clalancette added ready Work is about to start (Kanban column) and removed question Further information is requested labels Aug 4, 2017
@wjwwood
Copy link
Copy Markdown
Member Author

wjwwood commented Mar 1, 2018

Closing in favor of #119

@wjwwood wjwwood closed this Mar 1, 2018
@wjwwood wjwwood deleted the configure_fastrtps_ttl branch March 1, 2018 18:26
@wjwwood wjwwood removed the ready Work is about to start (Kanban column) label Mar 1, 2018
emersonknapp pushed a commit to aws-ros-dev/rcl that referenced this pull request Jun 3, 2019
@wjwwood
make log location parameter const (ros2#97)
8780784
ivanpauno pushed a commit that referenced this pull request Jan 2, 2020
@dirk-thomas
Merge pull request #97 from ros2/rmw_cmake_stuff
d5b8aff 
shuffle CMake code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wjwwood @mikaelarguedas @clalancette @sudpau01