Skip to content

fix tests on Windows#9

Closed
dirk-thomas wants to merge 1 commit intomasterfrom
fix_windows_tests
Closed

fix tests on Windows#9
dirk-thomas wants to merge 1 commit intomasterfrom
fix_windows_tests

Conversation

@dirk-thomas
Copy link
Copy Markdown
Member

Fixes all but one test. Connect to #8.

By using the same folder the test executables find the libraries of this package.

Before http://ci.ros2.org/job/ci_windows/868/testReport/
After http://ci.ros2.org/job/ci_windows/869/testReport/

@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Dec 19, 2015
@dirk-thomas dirk-thomas self-assigned this Dec 19, 2015
@gerkey
Copy link
Copy Markdown
Member

gerkey commented Dec 19, 2015

+1

Does this mean that we must always declare tests in the same CMakeLists.txt where we declare libraries that are being used by those test?

@wjwwood
Copy link
Copy Markdown
Member

wjwwood commented Dec 19, 2015

It's possible to make it work otherwise, but I'm not sure what the "right" approach is.

@dirk-thomas
Copy link
Copy Markdown
Member Author

That's exactly what I thought 😉 This way it find the libraries from the same package relative to the test executables. If we find an easy way to make it work they are in different folders we can change it anytime.

@spiked3
Copy link
Copy Markdown

spiked3 commented Dec 20, 2015

dirk,
I'd like to help out - can we have a short discussion? spiked@gmail.com sorry, I do not know of a better way to contact you

@wjwwood
Copy link
Copy Markdown
Member

wjwwood commented Dec 20, 2015

I think the right way to fix this would be to have an extra set of arguments for ament_add_*test:

  • APPEND_ENV: pairs of ENV_VAR, VALUE where VALUE is appended to ENV_VAR (or set to if it if doesn't exist yet), this is the general form
  • APPEND_LIBRARY_DIRS: list of paths which will be added to the system specific library path, i.e. LD_LIBRARY_PATH, DYLD_LIBRARY_PATH, or PATH

Then these values to be appended would be passed down to the test runner through a single --append-env argument in run_test.py.

We already have ENV which sets environment variables. I'm not sure if it is worth having PREPEND or REMOVE options for modifying environment variable as well.

@wjwwood
Copy link
Copy Markdown
Member

wjwwood commented Dec 31, 2015

Closed in favor of the other solution in #10.

@wjwwood wjwwood closed this Dec 31, 2015
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label Dec 31, 2015
@wjwwood wjwwood deleted the fix_windows_tests branch December 31, 2015 03:19
BorjaOuterelo referenced this pull request in micro-ROS/rcl Nov 5, 2018
ivanpauno pushed a commit that referenced this pull request Jan 2, 2020
mauropasse pushed a commit to mauropasse/rcl that referenced this pull request Nov 20, 2020
Move rcutils/executor_event_types.h to rmw/executor_event_types.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants