add explicit dependency on rcl_logging_log4cxx#435
Merged
dirk-thomas merged 1 commit intomasterfrom May 9, 2019
Merged
Conversation
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
wjwwood
approved these changes
May 9, 2019
clalancette
added a commit
that referenced
this pull request
May 14, 2019
This reverts commit 816ce67. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
dirk-thomas
pushed a commit
that referenced
this pull request
May 15, 2019
#436) * Revert "Changes the default 3rd party logger from rcl_logging_noop to rcl_logging_log4cxx (#425)" This reverts commit ac8ee90. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Revert "add explicit dependency on rcl_logging_log4cxx (#435)" This reverts commit 816ce67. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Add dependency on rcl_logging_noop. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes it possible for the devel / PR jobs to pass, e.g. http://build.ros2.org/view/Ddev/job/Ddev__rcl__ubuntu_bionic_amd64/21/