Add timer to action server to check expired goals + asan fixes#343
Merged
Add timer to action server to check expired goals + asan fixes#343
Conversation
6963a98 to
0fafffc
Compare
Contributor
Author
|
This one might conflict with #336 (will need to pass context to |
08922cc to
87a51cf
Compare
87a51cf to
d54001f
Compare
Contributor
Author
|
CI
|
wjwwood
approved these changes
Dec 1, 2018
Member
wjwwood
left a comment
There was a problem hiding this comment.
I had a question or two, due to my ignorance around the actions implementation, but the changes look reasonable so far as I can tell.
Contributor
Author
|
CI with 2aea0e3
|
wjwwood
approved these changes
Dec 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a timer to
rcl_action_server_tthat fires when an inactive goal handle expires and should be forgotten by the server. This tells the action server when it's time to check for expired goals.This also includes commits from #342 only because I need both for ros2/rclcpp#593. #342 should be merged first.I also included fixes for misc leaks/use after free/heap overflow reported by address sanitizer.
blocked by #336