Skip to content

rcl_action_expire_goals() outputs goals that expire#342

Merged
sloretz merged 4 commits intomasterfrom
output_expired_goals
Nov 29, 2018
Merged

rcl_action_expire_goals() outputs goals that expire#342
sloretz merged 4 commits intomasterfrom
output_expired_goals

Conversation

@sloretz
Copy link
Copy Markdown
Contributor

@sloretz sloretz commented Nov 28, 2018

The C++ action server needs to keep around the action result message until the goals expire. In order to know when it can throw away the result it needs to know when the rcl_action_server_t decided to expire the goal. This makes the API rcl_action_expire_goals() output the list of goals that expired.

@sloretz sloretz added the in review Waiting for review (Kanban column) label Nov 28, 2018
@sloretz sloretz added this to the crystal milestone Nov 28, 2018
@sloretz sloretz self-assigned this Nov 28, 2018
@sloretz sloretz requested a review from jacobperron November 28, 2018 20:32
@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Nov 28, 2018

CI

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Nov 28, 2018

CI attempt # 2

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Nov 28, 2018

CI attempt #3

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Copy link
Copy Markdown
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sloretz sloretz merged commit b2694df into master Nov 29, 2018
@sloretz sloretz deleted the output_expired_goals branch November 29, 2018 03:10
@sloretz sloretz removed the in review Waiting for review (Kanban column) label Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants