Skip to content

[rcl_action] Add function to check if goal can be transitioned to CANCELING#325

Merged
jacobperron merged 3 commits intomasterfrom
jacob/goal_cancelable
Nov 13, 2018
Merged

[rcl_action] Add function to check if goal can be transitioned to CANCELING#325
jacobperron merged 3 commits intomasterfrom
jacob/goal_cancelable

Conversation

@jacobperron
Copy link
Copy Markdown
Member

Add unit tests for the new function rcl_action_goal_handle_is_cancelable(), as well as rcl_action_goal_handle_is_active().

This is a useful function for the action server implementation (#323).

… CANCELING

Add unit tests for the new function rcl_action_goal_handle_is_cancelable(), as well as rcl_action_goal_handle_is_active().
@jacobperron jacobperron added the in progress Actively being worked on (Kanban column) label Nov 10, 2018
@jacobperron jacobperron self-assigned this Nov 10, 2018
@jacobperron jacobperron added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Nov 10, 2018
@jacobperron
Copy link
Copy Markdown
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Copy link
Copy Markdown
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* \return `true` if the goal handle is valid, `false` otherwise, also
* \return `false` if the goal handle pointer is null
* \return `true` if the goal handle is valid, or
* \return `false` if the goal handle pointer is null,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacobperron missing trailing or.

@jacobperron
Copy link
Copy Markdown
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@jacobperron jacobperron merged commit 8b00791 into master Nov 13, 2018
@jacobperron jacobperron removed the in review Waiting for review (Kanban column) label Nov 13, 2018
@jacobperron jacobperron deleted the jacob/goal_cancelable branch November 13, 2018 19:55
nburek pushed a commit to nburek/rcl that referenced this pull request Nov 26, 2018
…CELING (ros2#325)

* [rcl_action] Add function for checking if goal can be transitioned to CANCELING

Add unit tests for the new function rcl_action_goal_handle_is_cancelable(), as well as rcl_action_goal_handle_is_active().
nburek added a commit to nburek/rcl that referenced this pull request Nov 26, 2018
nburek added a commit to nburek/rcl that referenced this pull request Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants