[lifecycle] Add transitions from some states to shutting_down#310
Closed
fmrico wants to merge 1 commit intoros2:masterfrom
Closed
[lifecycle] Add transitions from some states to shutting_down#310fmrico wants to merge 1 commit intoros2:masterfrom
fmrico wants to merge 1 commit intoros2:masterfrom
Conversation
…ates to shutting_down
Author
|
Another solution could be just removing TRANSITION_SHUTDOWN from messages... |
hidmic
added a commit
that referenced
this pull request
Nov 7, 2018
hidmic
added a commit
that referenced
this pull request
Nov 12, 2018
hidmic
added a commit
that referenced
this pull request
Nov 13, 2018
nburek
pushed a commit
to nburek/rcl
that referenced
this pull request
Nov 26, 2018
nburek
added a commit
to nburek/rcl
that referenced
this pull request
Nov 26, 2018
This reverts commit 778fcbc.
nburek
added a commit
to nburek/rcl
that referenced
this pull request
Nov 26, 2018
This reverts commit 778fcbc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
If #309 is considered a bug, this PR fixed it. Otherwise, discard it.
TRANSITION_SHUTDOWN was specfied in messages, but this transition was not implemented.
http://design.ros2.org/articles/node_lifecycle.html specifies transitions from Unconfigured, Inactive and Active transitions to Shuttingdown state. This PR provides these transitions.
Best