Add test for 0ns wait on triggered guard condition#169
Merged
Conversation
dirk-thomas
approved these changes
Oct 18, 2017
Karsten1987
pushed a commit
that referenced
this pull request
Nov 11, 2017
ivanpauno
added a commit
that referenced
this pull request
Jan 2, 2020
* Added rmw_publisher_get_actual_qos function Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com> * Add RMW_QOS_POLICY_*_UNKNOWN enum value Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a test for non-blocking wait on a guard condition that has already triggered.
@sloretz noticed this wasn't working as expected when adding tests for wait sets in rclpy: https://github.com/ros2/rclpy/pull/127/files#r145215841
CI for this branch alone, showing that the new tests fails for fastrtps:
The fix for the test is in ros2/rmw_fastrtps#158