Change the starting time of the goal expiration timeout (backport #1121)#1240
Merged
Change the starting time of the goal expiration timeout (backport #1121)#1240
Conversation
Signed-off-by: Barry Xu <barry.xu@sony.com> (cherry picked from commit 30a047a)
Collaborator
|
@Barry-Xu-2018 we got lucky, there is no conflict. can you review this and run CI? |
Barry-Xu-2018
approved these changes
May 21, 2025
Contributor
|
Pulls: #1240
|
|
Thank you thank you! |
mjcarroll
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address one issue mentioned #1103
The expire timeout is being calculated from the time the goal was accepted. According to the design https://design.ros2.org/articles/actions.html#result-caching, it should be calculated from the time the goal is completed.
This is an automatic backport of pull request #1121 done by Mergify.