Add rcl_timer_call_with_info function#1113
Merged
mjcarroll merged 1 commit intoros2:rollingfrom Mar 26, 2024
Merged
Conversation
Contributor
Author
|
@clalancette ping |
Contributor
Author
|
@wjwwood @mjcarroll @fujitatomoya Ping, I would like to see this merged for jazzy |
205989d to
c09e77a
Compare
Contributor
Author
|
@mjcarroll Any more points from your side, or can we move forward with this PR ? |
Member
|
mjcarroll
approved these changes
Mar 22, 2024
Member
mjcarroll
left a comment
There was a problem hiding this comment.
LGTM with Green CI. Thanks for porting this feature forward from ROS 1.
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
@jmachowinski a few minor comments, can you check?
… the actual timer trigger times Co-authored-by: Michael Carroll <carroll.michael@gmail.com> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Alexis Tsogias <a.tsogias@cellumation.com> Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>
e10b4f3 to
fcc0ac8
Compare
fujitatomoya
approved these changes
Mar 25, 2024
Member
|
Will run this one more time once ros-perception/point_cloud_transport#72 lands |
Member
|
Member
|
Previous run was across the FastCDR update, updated to new repos file:
|
Member
|
CI has known flaky Windows tests, this is good to go. |
This was referenced May 15, 2024
apojomovsky
pushed a commit
to apojomovsky/rcl
that referenced
this pull request
May 16, 2024
… the actual timer trigger times (ros2#1113) Signed-off-by: Alexis Tsogias <a.tsogias@cellumation.com> Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com> Co-authored-by: Alexis Tsogias <a.tsogias@cellumation.com> Co-authored-by: Michael Carroll <carroll.michael@gmail.com> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
apojomovsky
pushed a commit
to apojomovsky/rcl
that referenced
this pull request
Jun 17, 2024
… the actual timer trigger times (ros2#1113) Signed-off-by: Alexis Tsogias <a.tsogias@cellumation.com> Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com> Co-authored-by: Alexis Tsogias <a.tsogias@cellumation.com> Co-authored-by: Michael Carroll <carroll.michael@gmail.com> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
apojomovsky
pushed a commit
to apojomovsky/rcl
that referenced
this pull request
Jun 26, 2024
… the actual timer trigger times (ros2#1113) Signed-off-by: Alexis Tsogias <a.tsogias@cellumation.com> Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com> Co-authored-by: Alexis Tsogias <a.tsogias@cellumation.com> Co-authored-by: Michael Carroll <carroll.michael@gmail.com> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
apojomovsky
pushed a commit
to irobot-ros/rcl
that referenced
this pull request
Aug 12, 2024
… the actual timer trigger times (ros2#1113) Signed-off-by: Alexis Tsogias <a.tsogias@cellumation.com> Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com> Co-authored-by: Alexis Tsogias <a.tsogias@cellumation.com> Co-authored-by: Michael Carroll <carroll.michael@gmail.com> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit is the precursor to re adding the 'TimerEvent' from ROS1.
This allows us to get the correct time of the timer callback as node->now() can
return a later timestamp than 'expected' due to race conditions.