Skip to content

Set disable loan to on by default.#1110

Merged
clalancette merged 1 commit intorollingfrom
clalancette/disable-executor-loan
Nov 2, 2023
Merged

Set disable loan to on by default.#1110
clalancette merged 1 commit intorollingfrom
clalancette/disable-executor-loan

Conversation

@clalancette
Copy link
Copy Markdown
Contributor

It is currently not safe to use; see the executor code in rclcpp for more information.

@clalancette clalancette marked this pull request as ready for review October 31, 2023 16:23
@clalancette
Copy link
Copy Markdown
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

It is currently not safe to use; see the executor code in
rclcpp for more information.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette clalancette force-pushed the clalancette/disable-executor-loan branch from 72a72bc to 4b08cca Compare October 31, 2023 18:04
@clalancette
Copy link
Copy Markdown
Contributor Author

clalancette commented Nov 2, 2023

Another CI try now that this has been rebased:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette
Copy link
Copy Markdown
Contributor Author

@Mergifyio backport humble iron

@mergify
Copy link
Copy Markdown

mergify bot commented Nov 9, 2023

backport humble iron

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Nov 9, 2023
It is currently not safe to use; see the executor code in
rclcpp for more information.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 1b01127)

# Conflicts:
#	rcl/include/rcl/subscription.h
#	rcl/src/rcl/subscription.c
#	rcl/test/rcl/test_subscription.cpp
mergify bot pushed a commit that referenced this pull request Nov 9, 2023
It is currently not safe to use; see the executor code in
rclcpp for more information.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 1b01127)
clalancette added a commit that referenced this pull request Nov 9, 2023
It is currently not safe to use; see the executor code in
rclcpp for more information.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 1b01127)

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
clalancette pushed a commit that referenced this pull request Nov 10, 2023
* Set disable loan to on by default. (#1110)

It is currently not safe to use; see the executor code in
rclcpp for more information.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 1b01127)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants