Dynamic Subscription (BONUS: Allocators): rcl#1057
Merged
methylDragon merged 4 commits intorollingfrom Apr 11, 2023
Merged
Conversation
28 tasks
wjwwood
approved these changes
Apr 10, 2023
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
bf196e1 to
3d654b1
Compare
wjwwood
approved these changes
Apr 10, 2023
| rosidl_message_type_support_t * ts) | ||
| { | ||
| RCUTILS_CHECK_ARGUMENT_FOR_NULL(ts, RCUTILS_RET_INVALID_ARGUMENT); | ||
| RCUTILS_CHECK_ARGUMENT_FOR_NULL(allocator, RCUTILS_RET_INVALID_ARGUMENT); |
Collaborator
There was a problem hiding this comment.
You maybe should also check
if (!rcutils_allocator_is_valid(&allocator)) {
You can have a non-null allocator that isn't initialized yet and can't be used
Contributor
Author
There was a problem hiding this comment.
I might defer this so we don't invalidate the windows debug CI run :x
Contributor
There was a problem hiding this comment.
You are going to have to re-run it anyway, since you changed all of the function signatures for rmw_init_serialization_support
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
danthony06
pushed a commit
to danthony06/rcl
that referenced
this pull request
Jun 14, 2023
* Refactor dynamic message type support init Signed-off-by: methylDragon <methylDragon@gmail.com> * Refactor serialization support to use allocators and refs Signed-off-by: methylDragon <methylDragon@gmail.com> * Use rmw_serialization_support_init Signed-off-by: methylDragon <methylDragon@gmail.com> * Check if allocator is initialized Signed-off-by: methylDragon <methylDragon@gmail.com> --------- Signed-off-by: methylDragon <methylDragon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: ros2/ros2#1405