Skip to content

Get up-to-date with upstream#24

Closed
MatthijsBurgh wants to merge 399 commits intoros2:ros2from
orocos:master
Closed

Get up-to-date with upstream#24
MatthijsBurgh wants to merge 399 commits intoros2:ros2from
orocos:master

Conversation

@MatthijsBurgh
Copy link
Copy Markdown

I really recommend getting up-to-date with the upstream repository.

It probably requires some work, as your repo is really out of date. But I think it is a better to keep a little bit in sync.

MatthijsBurgh and others added 30 commits May 7, 2020 00:43
(PyKDL) update pybind11 to 2.5.0
Fix memory leak in Path_Circle constructor. Fixes #177
add xml model to package.xml
(PyKDL) add (deep)copy test functions
Add (deep)copy support for PyKDL
(PyKDL) fix missing condition of build_depend
fix #251)

${pcfiledir} refers to the installed location of the .pc file.
Added @LIB_SUFFIX@ to libdir to match install destination in src/CMakeLists.txt.
CMake variable KDL_INCLUDE_DIRS was unused.
@jacobperron
Copy link
Copy Markdown
Member

@MatthijsBurgh I've opened orocos#366, though I think it's a good addition, I don't think it's strictly required for ROS 2 to link against orocos-kdl.

See ros2/ros2#1208 for a discussion on tracking upstream orocos-kdl.

@MatthijsBurgh
Copy link
Copy Markdown
Author

@jacobperron orocos#366 has been merged. Do you require more PRs?

dependabot Bot and others added 4 commits December 28, 2021 22:03
Bumps [python_orocos_kdl/pybind11](https://github.com/pybind/pybind11) from `acae930` to `9b4f71d`.
- [Release notes](https://github.com/pybind/pybind11/releases)
- [Commits](pybind/pybind11@acae930...9b4f71d)

---
updated-dependencies:
- dependency-name: python_orocos_kdl/pybind11
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Bump python_orocos_kdl/pybind11 from `acae930` to `9b4f71d`
* Skip building pybind11 if already available on system

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Update message

Co-authored-by: Matthijs van der Burgh <MatthijsBurgh@outlook.com>

Co-authored-by: Matthijs van der Burgh <MatthijsBurgh@outlook.com>
@MatthijsBurgh
Copy link
Copy Markdown
Author

@jacobperron any more PRs needed?

Bumps [python_orocos_kdl/pybind11](https://github.com/pybind/pybind11) from `9b4f71d` to `ffa3468`.
- [Release notes](https://github.com/pybind/pybind11/releases)
- [Commits](pybind/pybind11@9b4f71d...ffa3468)

---
updated-dependencies:
- dependency-name: python_orocos_kdl/pybind11
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@jacobperron
Copy link
Copy Markdown
Member

@MatthijsBurgh Sorry, I've been busy with other things lately. After a discussion with the team, I've created a "vendor" package for orocos_kdl that ensures the package is available on all supported platforms. As part of the process, I'm trying to get the Python bindings to work, which is where I'm currently stuck: ros2/orocos_kdl_vendor#1 (comment)

Basically, after building orocos_kdl from source I don't seem to be able to import PyKDL from a Python interpreter. Any ideas?

@MatthijsBurgh
Copy link
Copy Markdown
Author

@jacobperron I assume python is not able to find the pykdl*.so. In that case you need to do some investigation of the PYTHONPATH. It should include the path of where the library is located.

In case it can find the library, but fails to import. I could have issue finding the cpp library. That is a bit more difficult. But also not my expertise.

@jacobperron
Copy link
Copy Markdown
Member

Alright, I think I resolved the PYTHONPATH issue in the vendor package (thanks!).

Closing this PR in favor of ros2/ros2#1208.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants