Skip building pybind11 if already available on system#375
Merged
MatthijsBurgh merged 2 commits intoorocos:masterfrom Jan 7, 2022
Merged
Skip building pybind11 if already available on system#375MatthijsBurgh merged 2 commits intoorocos:masterfrom
MatthijsBurgh merged 2 commits intoorocos:masterfrom
Conversation
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
MatthijsBurgh
requested changes
Jan 7, 2022
Collaborator
MatthijsBurgh
left a comment
There was a problem hiding this comment.
Just a small change in a message.
Co-authored-by: Matthijs van der Burgh <MatthijsBurgh@outlook.com>
MatthijsBurgh
approved these changes
Jan 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example, ROS 2 currently ships with a version of pybind11 that we can use instead of building another version from source.