Add Python implementation for a Chain filter#213
Merged
ahcorde merged 2 commits intoros2:rollingfrom Oct 13, 2025
Merged
Conversation
03729f7 to
4cc9092
Compare
ahcorde
requested changes
Oct 13, 2025
test/test_message_filters_chain.py
Outdated
Comment on lines
+1
to
+2
| # Copyright 2015, Open Source Robotics Foundation, Inc. All rights reserved. | ||
| # Copyright 2015, Martin Llofriu. All rights reserved. |
Contributor
There was a problem hiding this comment.
Suggested change
| # Copyright 2015, Open Source Robotics Foundation, Inc. All rights reserved. | |
| # Copyright 2015, Martin Llofriu. All rights reserved. | |
| # Copyright 2025, Open Source Robotics Foundation, Inc. All rights reserved. |
test/test_message_filters_chain.py
Outdated
| from rclpy.time import Time | ||
| from std_msgs.msg import String | ||
|
|
||
| PKG = 'message_filters' |
test/test_message_filters_chain.py
Outdated
| @classmethod | ||
| def setUpClass(cls): | ||
| rclpy.init() | ||
| cls.node = rclpy.create_node('my_node', namespace='/my_ns') |
Contributor
There was a problem hiding this comment.
Suggested change
| cls.node = rclpy.create_node('my_node', namespace='/my_ns') | |
| cls.node = rclpy.create_node('TestChainNode', namespace='/my_ns') |
4cc9092 to
edf6a99
Compare
Signed-off-by: EsipovPA <esipov.p@mail.ru>
…ilters_chain.py Signed-off-by: EsipovPA <esipov.p@mail.ru>
edf6a99 to
612983f
Compare
Contributor
|
Pulls: #213
|
ahcorde
approved these changes
Oct 13, 2025
Contributor
|
https://github.com/Mergifyio backport kilted jazzy humble |
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 13, 2025
Signed-off-by: EsipovPA <esipov.p@mail.ru> (cherry picked from commit 0617849)
mergify bot
pushed a commit
that referenced
this pull request
Oct 13, 2025
Signed-off-by: EsipovPA <esipov.p@mail.ru> (cherry picked from commit 0617849) # Conflicts: # CMakeLists.txt # src/message_filters/__init__.py
mergify bot
pushed a commit
that referenced
this pull request
Oct 13, 2025
Signed-off-by: EsipovPA <esipov.p@mail.ru> (cherry picked from commit 0617849) # Conflicts: # CMakeLists.txt # src/message_filters/__init__.py
ahcorde
pushed a commit
that referenced
this pull request
Oct 14, 2025
ahcorde
added a commit
that referenced
this pull request
Oct 15, 2025
* Add Python implementation for a Chain filter (#213) Signed-off-by: EsipovPA <esipov.p@mail.ru> (cherry picked from commit 0617849) Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> Co-authored-by: Pavel Esipov <38457822+EsipovPA@users.noreply.github.com> Co-authored-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
ahcorde
added a commit
that referenced
this pull request
Oct 15, 2025
* Add Python implementation for a Chain filter (#213) Signed-off-by: EsipovPA <esipov.p@mail.ru> (cherry picked from commit 0617849) Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> Co-authored-by: Pavel Esipov <38457822+EsipovPA@users.noreply.github.com> Co-authored-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
Chainfilter implementation for PythonFixes #204
Is this user-facing behavior change?
Yes.
This change provides the functionality of a
Chainmessage filter for Python users.Did you use Generative AI?
No, I did not.
Additional Information