Skip to content

get rid of deprecated rclcpp::spin_some().#201

Merged
fujitatomoya merged 1 commit intorollingfrom
fujitatomoya/deprecate-global-spin-some-all
Aug 23, 2025
Merged

get rid of deprecated rclcpp::spin_some().#201
fujitatomoya merged 1 commit intorollingfrom
fujitatomoya/deprecate-global-spin-some-all

Conversation

@fujitatomoya
Copy link
Contributor

@fujitatomoya fujitatomoya commented Aug 20, 2025 •
edited
Loading

Description

This depends on ros2/rclcpp#2848

Fixes # (issue)

Is this user-facing behavior change?

No

Did you use Generative AI?

No

Additional Information

@fujitatomoya
get rid of deprecated rclcpp::spin_some().
84af729 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya fujitatomoya requested a review from alsora August 20, 2025 07:24
fujitatomoya
fujitatomoya commented Aug 20, 2025
View reviewed changes
Copy link
Contributor Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alsora requesting review along with ros2/rclcpp#2848

@fujitatomoya
Copy link
Contributor Author

fujitatomoya commented Aug 20, 2025

Pulls: ros2/rclcpp#2848, #201, ros2/system_tests#574, ros2/demos#734, ros2/examples#422, ros2/geometry2#821
Gist: https://gist.githubusercontent.com/fujitatomoya/729c2c9e3f31efc10217a07d09b682c5/raw/80936104a2cae37018c8996fb8071ceffb79df0c/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp rclcpp_action rclcpp_lifecycle message_filters test_communication test_rclcpp pendulum_control dummy_map_server dummy_sensors examples_rclcpp_minimal_publisher examples_rclcpp_minimal_action_client tf2_ros
TEST args: --packages-above rclcpp rclcpp_action rclcpp_lifecycle message_filters test_communication test_rclcpp pendulum_control dummy_map_server dummy_sensors examples_rclcpp_minimal_publisher examples_rclcpp_minimal_action_client tf2_ros
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16754

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

This was referenced Aug 20, 2025
Merged
Merged
Merged
Merged
Merged
@ahcorde
Copy link
Contributor

ahcorde commented Aug 22, 2025

Pulls: #201
Gist: https://gist.githubusercontent.com/ahcorde/d6f4bdec92fc07ddef083525e6b63161/raw/b0979a8b2aad16c8957f7e63b08f13b2f16d588b/ros2.repos
BUILD args: --packages-above-and-dependencies message_filters
TEST args: --packages-above message_filters
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16772

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Contributor Author

fujitatomoya commented Aug 23, 2025

@ahcorde @alsora thanks for reviews.

This depends on ros2/rclcpp#2848

this is NOT true, this PR just replaces into using Executor, so this does not have to go with ros2/rclcpp#2848. (i believe that is the intention that you started CI with this fix.)

after all, with green CI, we can go ahead to merge this.

@fujitatomoya fujitatomoya merged commit c5bc6de into rolling Aug 23, 2025
2 checks passed
@ahcorde ahcorde deleted the fujitatomoya/deprecate-global-spin-some-all branch August 25, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

@alsora alsora alsora approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fujitatomoya @ahcorde @alsora