Merged
Conversation
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
sloretz
reviewed
Mar 22, 2019
sloretz
reviewed
Mar 22, 2019
sloretz
reviewed
Mar 22, 2019
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Author
|
Tested component loading using @mjcarroll draft PR ros2/rclcpp#665 and these launch actions are working as expected. |
wjwwood
approved these changes
Mar 25, 2019
Author
|
@sloretz @mjcarroll is there anything else we want to get in before merging this? |
mjcarroll
approved these changes
Apr 16, 2019
Member
|
Nope, good to go from me |
Author
|
CI (up to
|
Author
|
Going in! |
TomohitoAndo
pushed a commit
to TomohitoAndo/launch_ros
that referenced
this pull request
Aug 27, 2025
feat(rclcpp_components): add glog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds
ComposableNodeContainerandLoadComposableNodesactions tolaunch_ros.Connected to #6. Copy of ros2/launch#197.