Skip to content

Correct typos#524

Merged
ahcorde merged 1 commit intoros2:rollingfrom
augustelalande:typos
Mar 9, 2026
Merged

Correct typos#524
ahcorde merged 1 commit intoros2:rollingfrom
augustelalande:typos

Conversation

@augustelalande
Copy link
Copy Markdown
Contributor

@augustelalande augustelalande commented Mar 5, 2026

Description

I ran a typo check using typos and codespell

ahcorde
ahcorde requested changes Mar 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind to sign the commit ?

https://github.com/ros2/launch_ros/pull/524/checks?check_run_id=65830256492

fujitatomoya
fujitatomoya reviewed Mar 5, 2026
View reviewed changes
@augustelalande
correct typos
9fef576 
Signed-off-by: augustelalande <auguste.lalande@gmail.com>
@augustelalande
Copy link
Copy Markdown
Contributor Author

augustelalande commented Mar 5, 2026

signed and removed CHANGELOG

@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Mar 6, 2026

Pulls: #524
Gist: https://gist.githubusercontent.com/ahcorde/be59679ff10538a2bc728ecb5e28e1ce/raw/dd49918cb195d5db5b9991ad2a90a8535560368f/ros2.repos
BUILD args: --packages-above-and-dependencies launch_ros launch_testing_ros test_launch_ros ros2launch
TEST args: --packages-above launch_ros launch_testing_ros test_launch_ros ros2launch
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18374

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 26828a6 into ros2:rolling Mar 9, 2026
2 of 3 checks passed
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Mar 9, 2026

https://github.com/Mergifyio backport kilted jazzy humble

@mergify
Copy link
Copy Markdown

mergify bot commented Mar 9, 2026 •
edited
Loading

backport kilted jazzy humble

✅ Backports have been created

Details

Cherry-pick of 26828a6 has failed:

On branch mergify/bp/kilted/pr-524
Your branch is up to date with 'origin/kilted'.

You are currently cherry-picking commit 26828a6.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   launch_ros/launch_ros/actions/lifecycle_transition.py
	modified:   launch_ros/launch_ros/parameter_descriptions.py
	modified:   launch_ros/launch_ros/utilities/evaluate_parameters.py
	modified:   launch_testing_ros/launch_testing_ros/data_republisher.py
	modified:   ros2launch/ros2launch/command/launch.py
	modified:   test_launch_ros/test/test_launch_ros/actions/test_lifecycle_node.py
	modified:   test_launch_ros/test/test_launch_ros/actions/test_lifecycle_transition.py
	modified:   test_launch_ros/test/test_launch_ros/descriptions/test_parameter.py
	modified:   test_launch_ros/test/test_launch_ros/utilities/test_normalize_parameters.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   launch_ros/launch_ros/actions/load_composable_nodes.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Cherry-pick of 26828a6 has failed:

On branch mergify/bp/jazzy/pr-524
Your branch is up to date with 'origin/jazzy'.

You are currently cherry-picking commit 26828a6.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   launch_ros/launch_ros/actions/lifecycle_transition.py
	modified:   launch_ros/launch_ros/parameter_descriptions.py
	modified:   launch_ros/launch_ros/utilities/evaluate_parameters.py
	modified:   launch_testing_ros/launch_testing_ros/data_republisher.py
	modified:   ros2launch/ros2launch/command/launch.py
	modified:   test_launch_ros/test/test_launch_ros/actions/test_lifecycle_node.py
	modified:   test_launch_ros/test/test_launch_ros/actions/test_lifecycle_transition.py
	modified:   test_launch_ros/test/test_launch_ros/descriptions/test_parameter.py
	modified:   test_launch_ros/test/test_launch_ros/utilities/test_normalize_parameters.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   launch_ros/launch_ros/actions/load_composable_nodes.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Cherry-pick of 26828a6 has failed:

On branch mergify/bp/humble/pr-524
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 26828a6.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   launch_ros/launch_ros/actions/lifecycle_transition.py
	modified:   launch_ros/launch_ros/parameter_descriptions.py
	modified:   launch_ros/launch_ros/utilities/evaluate_parameters.py
	modified:   launch_testing_ros/launch_testing_ros/data_republisher.py
	modified:   ros2launch/ros2launch/command/launch.py
	modified:   test_launch_ros/test/test_launch_ros/actions/test_lifecycle_node.py
	modified:   test_launch_ros/test/test_launch_ros/actions/test_lifecycle_transition.py
	modified:   test_launch_ros/test/test_launch_ros/descriptions/test_parameter.py
	modified:   test_launch_ros/test/test_launch_ros/utilities/test_normalize_parameters.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   launch_ros/launch_ros/actions/load_composable_nodes.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

mergify bot pushed a commit that referenced this pull request Mar 9, 2026
@augustelalande @mergify
correct typos (#524)
fef69ce 
Signed-off-by: augustelalande <auguste.lalande@gmail.com>
(cherry picked from commit 26828a6)

# Conflicts:
#	launch_ros/launch_ros/actions/load_composable_nodes.py
@mergify mergify bot mentioned this pull request Mar 9, 2026
Merged
mergify bot pushed a commit that referenced this pull request Mar 9, 2026
@augustelalande @mergify
correct typos (#524)
2a33c62 
Signed-off-by: augustelalande <auguste.lalande@gmail.com>
(cherry picked from commit 26828a6)

# Conflicts:
#	launch_ros/launch_ros/actions/load_composable_nodes.py
@mergify mergify bot mentioned this pull request Mar 9, 2026
Merged
mergify bot pushed a commit that referenced this pull request Mar 9, 2026
@augustelalande @mergify
correct typos (#524)
61e42cd 
Signed-off-by: augustelalande <auguste.lalande@gmail.com>
(cherry picked from commit 26828a6)

# Conflicts:
#	launch_ros/launch_ros/actions/load_composable_nodes.py
@mergify mergify bot mentioned this pull request Mar 9, 2026
Merged
@augustelalande augustelalande deleted the typos branch March 9, 2026 15:51
ahcorde added a commit that referenced this pull request Mar 9, 2026
@mergify @augustelalande @ahcorde
Correct typos (backport #524) (#526)
a4580bd 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Co-authored-by: Auguste Lalande <auguste.lalande@gmail.com>
Co-authored-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
ahcorde added a commit that referenced this pull request Mar 9, 2026
@mergify @augustelalande @ahcorde
Correct typos (backport #524) (#527)
5e2bfc7 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Co-authored-by: Auguste Lalande <auguste.lalande@gmail.com>
Co-authored-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
ahcorde added a commit that referenced this pull request Mar 9, 2026
@mergify @augustelalande @ahcorde
Correct typos (backport #524) (#525)
ffcf148 
* correct typos (#524)ros/rosdistro#50187

Signed-off-by: augustelalande <auguste.lalande@gmail.com>
(cherry picked from commit 26828a6)
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Co-authored-by: Auguste Lalande <auguste.lalande@gmail.com>
Co-authored-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fujitatomoya fujitatomoya fujitatomoya left review comments

@ahcorde ahcorde ahcorde requested changes

@mjcarroll mjcarroll mjcarroll approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@augustelalande @ahcorde @mjcarroll @fujitatomoya