Skip to content

Compatiblity with 'Populate Transitions' ros2/rcl#1269#495

Merged
fujitatomoya merged 1 commit intoros2:rollingfrom
SuperJappie08:rolling-lifecycle-transition-event
Feb 4, 2026
Merged

Compatiblity with 'Populate Transitions' ros2/rcl#1269#495
fujitatomoya merged 1 commit intoros2:rollingfrom
SuperJappie08:rolling-lifecycle-transition-event

Conversation

@SuperJappie08
Copy link
Copy Markdown
Contributor

@SuperJappie08 SuperJappie08 commented Nov 5, 2025

Description

Compatibility with ros2/rcl#1269 and ros2/rcl_interfaces#185

Updates the StateTransition event to reflect the changes made in the message.

Is this user-facing behavior change?

Yes, the timestamp field of the StateTransition event has been replaced with stamp of type builtin_interfaces.msg.Time (instead of int).

Did you use Generative AI?

No

Additional Information

Requires ros2/rcl_interfaces#185

@SuperJappie08 SuperJappie08 mentioned this pull request Nov 5, 2025
Merged
fujitatomoya
fujitatomoya approved these changes Nov 5, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fujitatomoya
Copy link
Copy Markdown
Contributor

fujitatomoya commented Nov 5, 2025

@emersonknapp can you review this?

emersonknapp
emersonknapp approved these changes Nov 6, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good to me.

Note: not a candidate for backport.

@sloretz
Copy link
Copy Markdown
Contributor

sloretz commented Nov 20, 2025

Pulls: #495, ros2/rcl_interfaces#185
Gist: https://gist.githubusercontent.com/sloretz/2373c2eca285592fddd7aade80febec1/raw/891eff0bda659f5023899d63651bc55f55e77dfd/ros2.repos
BUILD args:
TEST args:
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17548

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@SuperJappie08
Copy link
Copy Markdown
Contributor Author

SuperJappie08 commented Nov 20, 2025

@sloretz, for some reason only RHEL cloned the correct launch_ros repository.

@fujitatomoya
Copy link
Copy Markdown
Contributor

fujitatomoya commented Feb 2, 2026

@Mergifyio rebase

@mergify
Copy link
Copy Markdown

mergify bot commented Feb 2, 2026

rebase

❌ Pull request can't be updated with latest base branch changes

Details

This pull request seems to come from a fork, and Mergify needs the author's permission to update its branch.
The author needs to enable "Allow edits from maintainers" on this pull request, or update the branch manually.

@SuperJappie08
Compatiblity with 'Populate Transitions' ros2/rcl#1269
6cac397 
Signed-off-by: SuperJappie08 <36795178+SuperJappie08@users.noreply.github.com>
@SuperJappie08 SuperJappie08 force-pushed the rolling-lifecycle-transition-event branch from d1dafc1 to 6cac397 Compare February 2, 2026 09:08
This was referenced Feb 2, 2026
Merged
Merged
@fujitatomoya
Copy link
Copy Markdown
Contributor

fujitatomoya commented Feb 2, 2026

Pulls: ros2/rcl_interfaces#185, ros2/rcl#1269, ros2/rclcpp#2967, ros2/rclpy#1528, #495
Gist: https://gist.githubusercontent.com/fujitatomoya/509dc37f463751da80d68854d37ec1d0/raw/5f7a4fa0c2b57380aa59f72196e8279872b6a096/ros2.repos
BUILD args: --packages-above-and-dependencies lifecycle_msgs rcl_lifecycle rclcpp_lifecycle rclpy launch_ros
TEST args: --packages-above lifecycle_msgs rcl_lifecycle rclcpp_lifecycle rclpy launch_ros
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18088

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya mentioned this pull request Feb 2, 2026
Merged
@fujitatomoya
Copy link
Copy Markdown
Contributor

fujitatomoya commented Feb 3, 2026

they all passed (eventually with retries)

For completeness:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya merged commit 4f7e8da into ros2:rolling Feb 4, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emersonknapp emersonknapp emersonknapp approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SuperJappie08 @fujitatomoya @sloretz @emersonknapp