Skip to content

[Backport]cache lookup of importlib metadata in Node action (#365)#411

Merged
ahcorde merged 1 commit intoros2:ironfrom
roscan-tech:bp/iron/pr-365
Oct 4, 2024
Merged

[Backport]cache lookup of importlib metadata in Node action (#365)#411
ahcorde merged 1 commit intoros2:ironfrom
roscan-tech:bp/iron/pr-365

Conversation

@roscan-tech
Copy link
Copy Markdown

  • cache lookup of importlib metadata in Node action

  • style fixup


* cache lookup of importlib metadata in Node action

Signed-off-by: William Woodall <william@osrfoundation.org>

* style fixup

Signed-off-by: William Woodall <william@osrfoundation.org>

---------

Signed-off-by: William Woodall <william@osrfoundation.org>
Copy link
Copy Markdown
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the backport of #365, lgtm with green CI

@fujitatomoya
Copy link
Copy Markdown
Contributor

Pulls: #411
Gist: https://gist.githubusercontent.com/fujitatomoya/6e78c91e4f960e1f5b44b21cd1f5fe27/raw/45343762765666b2939dfd3e255774339b3e60bd/ros2.repos
BUILD args: --packages-above-and-dependencies launch_ros
TEST args: --packages-above launch_ros
ROS Distro: iron
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14667

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Oct 4, 2024

RHEL warnings are unrelated. Merging

@ahcorde ahcorde merged commit eb66680 into ros2:iron Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants