Launch testing examples : ROS focused#263
Merged
adityapande-1995 merged 13 commits intomasterfrom Sep 16, 2021
Merged
Conversation
Signed-off-by: Aditya Pande <aditya050995@gmail.com>
Signed-off-by: Aditya Pande <aditya050995@gmail.com>
Signed-off-by: Aditya Pande <aditya050995@gmail.com>
Signed-off-by: Aditya Pande <aditya050995@gmail.com>
wjwwood
reviewed
Sep 1, 2021
ivanpauno
reviewed
Sep 2, 2021
Member
ivanpauno
left a comment
There was a problem hiding this comment.
the examples look reasonable
ivanpauno
reviewed
Sep 2, 2021
Signed-off-by: Aditya Pande <aditya050995@gmail.com>
Signed-off-by: Aditya Pande <aditya050995@gmail.com>
Signed-off-by: Aditya Pande <aditya050995@gmail.com>
Signed-off-by: Aditya Pande <aditya050995@gmail.com>
Signed-off-by: Aditya Pande <aditya050995@gmail.com>
wjwwood
approved these changes
Sep 15, 2021
Member
wjwwood
left a comment
There was a problem hiding this comment.
Spoke with @adityapande-1995 offline and we're just gonna make follow up issues for all the remaining comments I had.
Contributor
Author
|
CI :
|
Signed-off-by: Aditya Pande <aditya050995@gmail.com>
Contributor
Author
|
CI round 2 :
|
ivanpauno
approved these changes
Sep 16, 2021
Signed-off-by: Aditya Pande <aditya050995@gmail.com>
wjwwood
approved these changes
Sep 16, 2021
Signed-off-by: Aditya Pande <aditya050995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Launch testing improvement : More examples
This PR aims to add simpler, easier to follow examples to demonstrate the usage of
launch_testing. The code here is intended to be boilerplate code for beginners, and must showcase the power and scope of launch_testing. These should cover a wide range of common use cases of testing and launch.The README.rst should explain the examples in sufficient detail.
Suggestions are welcome for new test cases, problem statements, and the example code.
Added test cases :
✅ Hello world (Moved to ros2/launch#532)
✅ Set a parameter on a node , check if successful.
✅ Check if a topic is publishing messages.
✅ Check if a node is running
Status : In progress
Main issue tracking related PRs : ros2/launch#531
Signed-off-by: Aditya Pande aditya050995@gmail.com