Add a "hello world" style example#532
Merged
adityapande-1995 merged 7 commits intomasterfrom Sep 15, 2021
Merged
Conversation
Signed-off-by: Aditya Pande <aditya050995@gmail.com>
This was referenced Sep 13, 2021
Signed-off-by: Aditya Pande <aditya050995@gmail.com>
Signed-off-by: Aditya Pande <aditya050995@gmail.com>
jacobperron
reviewed
Sep 13, 2021
Member
jacobperron
left a comment
There was a problem hiding this comment.
I think this is a nice minimal example. Are you planning to create a more detailed guide on ros2/ros2_documentation to go along with this? If not, I think we could provide more explanation with more comments in the code and maybe in the README.
Signed-off-by: Aditya Pande <aditya050995@gmail.com>
Contributor
Author
|
I'm planning to add a page to |
Signed-off-by: Aditya Pande <aditya050995@gmail.com>
jacobperron
approved these changes
Sep 14, 2021
Contributor
Author
Signed-off-by: Aditya Pande <aditya050995@gmail.com>
Contributor
Author
jacobperron
approved these changes
Sep 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to add a "hello world" style basic example meant to show the general structure of launch tests.
Signed-off-by: Aditya Pande aditya050995@gmail.com