Skip to content

Add a "hello world" style example#532

Merged
adityapande-1995 merged 7 commits intomasterfrom
aditya/hello_world_example
Sep 15, 2021
Merged

Add a "hello world" style example#532
adityapande-1995 merged 7 commits intomasterfrom
aditya/hello_world_example

Conversation

@adityapande-1995
Copy link
Copy Markdown
Contributor

This PR aims to add a "hello world" style basic example meant to show the general structure of launch tests.

Signed-off-by: Aditya Pande aditya050995@gmail.com

Signed-off-by: Aditya Pande <aditya050995@gmail.com>
Signed-off-by: Aditya Pande <aditya050995@gmail.com>
Signed-off-by: Aditya Pande <aditya050995@gmail.com>
Copy link
Copy Markdown
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a nice minimal example. Are you planning to create a more detailed guide on ros2/ros2_documentation to go along with this? If not, I think we could provide more explanation with more comments in the code and maybe in the README.

Signed-off-by: Aditya Pande <aditya050995@gmail.com>
@adityapande-1995
Copy link
Copy Markdown
Contributor Author

I'm planning to add a page to ros2_documentation explaining the examples, but adding comments is a good idea actually.

Signed-off-by: Aditya Pande <aditya050995@gmail.com>
Copy link
Copy Markdown
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example LGTM!

@adityapande-1995
Copy link
Copy Markdown
Contributor Author

CI :

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Signed-off-by: Aditya Pande <aditya050995@gmail.com>
Signed-off-by: Aditya Pande <aditya050995@gmail.com>
@adityapande-1995
Copy link
Copy Markdown
Contributor Author

CI :

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@adityapande-1995 adityapande-1995 merged commit 026ab0e into master Sep 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the aditya/hello_world_example branch September 15, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants