Merged
Conversation
Invalid if type coerced using YAML rules. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Author
|
CI up to
|
j-rivero
approved these changes
Jul 30, 2020
j-rivero
left a comment
There was a problem hiding this comment.
I don't see any problem in code changes (obviously), just a bit afraid that we remember to indeed revisit it. Does it make sense to add them to ros2/launch#438?
Author
jacobperron
pushed a commit
that referenced
this pull request
Sep 10, 2021
Invalid if type coerced using YAML rules. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
jacobperron
pushed a commit
that referenced
this pull request
Nov 16, 2021
Invalid if type coerced using YAML rules. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are invalid if type coerced using YAML rules. Follow-up after ros2/launch#438.
May be revisited to use explicitly given type once #137 lands.