Merged
Conversation
Fix ros2#145 1. Make test names more intelligible by not parameterizing on a crazy long string 2. Don't leak StringIO objects Signed-off-by: Dan Rose <dan@digilabs.io>
…frontend Signed-off-by: Dan Rose <dan@digilabs.io>
hidmic
approved these changes
May 14, 2020
test_launch_ros/test/test_launch_ros/frontend/test_push_ros_namespace_frontend.py
Show resolved
Hide resolved
|
@rotu are you pushing this out of the draft state? |
Signed-off-by: Dan Rose <dan@digilabs.io>
Signed-off-by: Dan Rose <dan@digilabs.io>
Signed-off-by: Dan Rose <dan@digilabs.io>
|
CI up to
|
|
Given the nature of this patch, I'd think cross platform CI results won't differ from the ones we got for Linux. CC @jacobperron for final approval. |
ivanpauno
reviewed
May 21, 2020
test_launch_ros/test/test_launch_ros/frontend/test_node_frontend.py
Outdated
Show resolved
Hide resolved
Member
|
@hidmic I didn't take a close look at the change, but if it's just touching test code I don't see any reason to hold for Foxy. |
Signed-off-by: Dan Rose <dan@digilabs.io>
Member
|
@hidmic is this ready? |
|
@ivanpauno it is, thank for the bump. @rotu thanks for your contribution and sorry for the delay. |
jacobperron
pushed a commit
that referenced
this pull request
Sep 10, 2021
* Fix test_node_frontend Fix #145 1. Make test names more intelligible by not parameterizing on a crazy long string 2. Don't leak StringIO objects Signed-off-by: Dan Rose <dan@digilabs.io> * Some renamings and perform the same fixes on test_push_ros_namespace_frontend Signed-off-by: Dan Rose <dan@digilabs.io> * Remove incorrect docstring Signed-off-by: Dan Rose <dan@digilabs.io> * Add copyright for files with contributions Signed-off-by: Dan Rose <dan@digilabs.io> * Fix formatting Signed-off-by: Dan Rose <dan@digilabs.io> * Fix copyrights Signed-off-by: Dan Rose <dan@digilabs.io>
jacobperron
pushed a commit
that referenced
this pull request
Nov 16, 2021
* Fix test_node_frontend Fix #145 1. Make test names more intelligible by not parameterizing on a crazy long string 2. Don't leak StringIO objects Signed-off-by: Dan Rose <dan@digilabs.io> * Some renamings and perform the same fixes on test_push_ros_namespace_frontend Signed-off-by: Dan Rose <dan@digilabs.io> * Remove incorrect docstring Signed-off-by: Dan Rose <dan@digilabs.io> * Add copyright for files with contributions Signed-off-by: Dan Rose <dan@digilabs.io> * Fix formatting Signed-off-by: Dan Rose <dan@digilabs.io> * Fix copyrights Signed-off-by: Dan Rose <dan@digilabs.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #145
Signed-off-by: Dan Rose dan@digilabs.io