Improve jUnit output for launch tests when run with py.test#404
Merged
Improve jUnit output for launch tests when run with py.test#404
Conversation
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
dirk-thomas
approved these changes
Apr 20, 2020
Member
dirk-thomas
left a comment
There was a problem hiding this comment.
Super fragile but since the current state is strictly worse... 👍
This should really be revisited - so adding a TODO / follow up ticket would be good.
Author
I agree. I tried hard to make this better, but I was unable to without turning |
Author
|
See #405. I'll merge this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #400. I'll start by saying that while I'm not super happy with this patch -- it relies a bit too much on
pytestinternals --, it's the one I could come up with without undergoing major surgery.CI (up to
launch_testingandros2topic)