Skip to content

Add parsing methods for SetEnviromentVariable and UnsetEnviromentVariable#272

Merged
ivanpauno merged 2 commits intomasterfrom
ivanpauno/set-unset-env-var-paring-methods
Jul 16, 2019
Merged

Add parsing methods for SetEnviromentVariable and UnsetEnviromentVariable#272
ivanpauno merged 2 commits intomasterfrom
ivanpauno/set-unset-env-var-paring-methods

Conversation

@ivanpauno
Copy link
Copy Markdown
Member

Follow up of #226.

Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added enhancement New feature or request in review Waiting for review (Kanban column) labels Jul 16, 2019
@ivanpauno ivanpauno requested a review from hidmic July 16, 2019 12:50
@ivanpauno ivanpauno self-assigned this Jul 16, 2019
Copy link
Copy Markdown

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but for a couple nits.

Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
@ivanpauno
Copy link
Copy Markdown
Member Author

CI (up to launch, launch_xml, launch_yaml, launch_ros, test_launch_ros, only fastrtps):

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno ivanpauno merged commit b6ed340 into master Jul 16, 2019
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/set-unset-env-var-paring-methods branch July 16, 2019 18:13
piraka9011 pushed a commit to aws-ros-dev/launch that referenced this pull request Aug 16, 2019
…able (ros2#272)

Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request in review Waiting for review (Kanban column)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants