Skip to content

Move code from examples tests#15

Merged
esteve merged 1 commit intomasterfrom
refactor
Nov 24, 2015
Merged

Move code from examples tests#15
esteve merged 1 commit intomasterfrom
refactor

Conversation

@esteve
Copy link
Copy Markdown
Member

@esteve esteve commented Nov 21, 2015

Extracted code from the examples tests so that it can be reused more easily.

Connects to ros2/ros2#143

@esteve esteve added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Nov 21, 2015
@esteve esteve self-assigned this Nov 21, 2015
@esteve esteve mentioned this pull request Nov 21, 2015
Merged
dirk-thomas
dirk-thomas reviewed Nov 21, 2015
View reviewed changes
launch_testing/launch_testing/__init__.py Outdated
Copy link
Copy Markdown
Member

@dirk-thomas dirk-thomas Nov 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please pass keyword arguments with the keyword.

Same below.

Copy link
Copy Markdown
Member Author

@esteve esteve Nov 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

dirk-thomas
dirk-thomas reviewed Nov 23, 2015
View reviewed changes
launch_testing/launch_testing/__init__.py Outdated
Copy link
Copy Markdown
Member

@dirk-thomas dirk-thomas Nov 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if instead of elif.

Same below.

Copy link
Copy Markdown
Member Author

@esteve esteve Nov 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@esteve esteve force-pushed the refactor branch 2 times, most recently from b9c6e07 to 92a17f8 Compare November 23, 2015 18:46
dirk-thomas
dirk-thomas reviewed Nov 23, 2015
View reviewed changes
launch_testing/launch_testing/__init__.py
Copy link
Copy Markdown
Member

@dirk-thomas dirk-thomas Nov 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function lacks return statement.

Copy link
Copy Markdown
Member Author

@esteve esteve Nov 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All functions return None by default

@dirk-thomas
Copy link
Copy Markdown
Member

dirk-thomas commented Nov 23, 2015

Please lint the code.

@esteve
Copy link
Copy Markdown
Member Author

esteve commented Nov 23, 2015

Linters enabled and the code passes them.

@esteve
Copy link
Copy Markdown
Member Author

esteve commented Nov 23, 2015

Pushed as test-services-examples, CI jobs:

http://ci.ros2.org/job/ci_linux/626/
http://ci.ros2.org/job/ci_osx/515/
http://ci.ros2.org/job/ci_windows_connext_dynamic/14/
http://ci.ros2.org/job/ci_windows_connext_static/14/
http://ci.ros2.org/job/ci_windows_opensplice/697/

@esteve
Copy link
Copy Markdown
Member Author

esteve commented Nov 23, 2015

New tests pass on Linux and launch_testing passes the linters:

http://ci.ros2.org/job/ci_linux/626/testReport/%28root%29/test_add_two_ints_client_add_two_ints_server__rmw_connext_cpp/
http://ci.ros2.org/job/ci_linux/626/testReport/%28root%29/test_add_two_ints_client_add_two_ints_server__rmw_connext_dynamic_cpp/
http://ci.ros2.org/job/ci_linux/626/testReport/%28root%29/test_add_two_ints_client_add_two_ints_server__rmw_opensplice_cpp/
http://ci.ros2.org/job/ci_linux/626/testReport/%28root%29/test_add_two_ints_client_async_add_two_ints_server__rmw_connext_cpp/
http://ci.ros2.org/job/ci_linux/626/testReport/%28root%29/test_add_two_ints_client_async_add_two_ints_server__rmw_connext_dynamic_cpp/
http://ci.ros2.org/job/ci_linux/626/testReport/%28root%29/test_add_two_ints_client_async_add_two_ints_server__rmw_opensplice_cpp/

@dirk-thomas
Copy link
Copy Markdown
Member

dirk-thomas commented Nov 23, 2015

lgtm.

esteve added a commit that referenced this pull request Nov 24, 2015
@esteve
Merge pull request #15 from ros2/refactor
597b238 
Move code from examples tests
@esteve esteve merged commit 597b238 into master Nov 24, 2015
@esteve esteve removed the in review Waiting for review (Kanban column) label Nov 24, 2015
@esteve esteve deleted the refactor branch November 24, 2015 00:27
dirk-thomas
dirk-thomas reviewed Dec 8, 2015
View reviewed changes
launch_testing/launch_testing/__init__.py
Copy link
Copy Markdown
Member

@dirk-thomas dirk-thomas Dec 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate line removed in 3b4ea2e.

Copy link
Copy Markdown
Member Author

@esteve esteve Dec 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

wjwwood pushed a commit that referenced this pull request Mar 20, 2019
@pbaughman
Merge pull request #15 from ApexAI/fix_coverage
3cdf135 
Fix coverage report
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@esteve esteve

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@esteve @dirk-thomas