Fixed inconsistency of C++ and Python implementations of StaticTransformPublisher#820
Merged
ahcorde merged 2 commits intoros2:rollingfrom Aug 20, 2025
Merged
Conversation
Signed-off-by: Dominik Authaler <dominik.authaler@uni-ulm.de>
Signed-off-by: Dominik Authaler <dominik.authaler@uni-ulm.de>
Contributor
|
Pulls: #820 |
ahcorde
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #818
I removed the previously used set of child_frame_ids in order to mimic the C++ implementation closely (for reference, the C++ implementation can be found here)
Is this user-facing behavior change?
Yes, the Python implementation of the StaticTransformPublisher now behaves as expected and allows updating previously published transforms.
Did you use Generative AI?
No.