Enable StaticTransformBroadcaster in Intra-process enabled components#607
Merged
clalancette merged 4 commits intoros2:rollingfrom Jun 22, 2023
Merged
Enable StaticTransformBroadcaster in Intra-process enabled components#607clalancette merged 4 commits intoros2:rollingfrom
clalancette merged 4 commits intoros2:rollingfrom
Conversation
clalancette
requested changes
Jun 21, 2023
Contributor
clalancette
left a comment
There was a problem hiding this comment.
Two small changes, then I'll run CI on it.
Contributor
Author
|
I also added a small test as I did for the TransformListener :) |
clalancette
approved these changes
Jun 22, 2023
Contributor
clalancette
left a comment
There was a problem hiding this comment.
Looks good, thanks for the addition of the test!
Contributor
Author
|
@clalancette wait wait, I missed some fixes to the comments EDIT: done, just need to see if uncrustify is happy with different newlines in the comment blocks. Sorry again for that :) |
Contributor
|
CI:
|
Contributor
Author
|
Thanks a lot! Can we backport to iron and humble? |
Contributor
|
https://github.com/Mergifyio backport iron humble |
Contributor
✅ Backports have been createdDetails
|
This was referenced Jun 23, 2023
ahcorde
pushed a commit
that referenced
this pull request
Jun 30, 2023
clalancette
pushed a commit
that referenced
this pull request
Jul 10, 2023
… (backport #607) (#612) * Enable StaticTransformBroadcaster in Intra-process enabled components (#607) * Update static_transform_broadcaster.h (cherry picked from commit edad1bc) Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Patrick Roncagliolo <ronca.pat@gmail.com>
This was referenced Sep 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of this comment made by @FranzAlbers (and PR #572 in general).
FYI @nachovizzo(PRBonn/kiss-icp#171) and @Fixit-Davide.