Allow to construct TransformBroadcaster and TransformListener from node interfaces#552
Merged
clalancette merged 5 commits intoros2:rollingfrom Sep 19, 2022
Merged
Conversation
Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>
Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>
Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>
Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>
Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>
clalancette
approved these changes
Sep 19, 2022
Contributor
clalancette
left a comment
There was a problem hiding this comment.
This looks good to me. Will run CI on it next.
Contributor
|
CI:
|
alsora
added a commit
to irobot-ros/geometry2
that referenced
this pull request
Sep 23, 2022
Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>
alsora
added a commit
to irobot-ros/geometry2
that referenced
this pull request
Sep 23, 2022
Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>
alsora
added a commit
to irobot-ros/geometry2
that referenced
this pull request
Sep 26, 2022
…m node interfaces (ros2#552) * add constructors for tf objects that accept node interfaces as arguments Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds new constructors for
TransformBroadcasterandTransformListenerthat do not require to have access to a full node, but rather can use only the required node interfaces.