Skip to content

Depend on orocos_kdl_vendor #473

Merged
jacobperron merged 2 commits intoros2from
jacob/upstream_orocos_kdl
Apr 4, 2022
Merged

Depend on orocos_kdl_vendor #473
jacobperron merged 2 commits intoros2from
jacob/upstream_orocos_kdl

Conversation

@jacobperron
Copy link
Copy Markdown
Member

@jacobperron jacobperron commented Oct 28, 2021 •
edited
Loading

  • Change package.xml dependency to the vendor package
  • Add missing include directories for orocos_kdl
  • Install tf2_kdl as a header-only target

Connects to ros2/ros2#1208

@jacobperron jacobperron self-assigned this Oct 28, 2021
@jacobperron jacobperron mentioned this pull request Oct 28, 2021
Merged
@jacobperron jacobperron force-pushed the jacob/upstream_orocos_kdl branch from 7ba8e93 to 33b917b Compare January 6, 2022 23:41
@jacobperron jacobperron force-pushed the jacob/upstream_orocos_kdl branch from 33b917b to 6df4941 Compare February 24, 2022 04:51
@jacobperron jacobperron changed the title Fix linking against orocos-kdl Depend on orocos_kdl_vendor Feb 24, 2022
@jacobperron jacobperron marked this pull request as ready for review February 24, 2022 05:05
@jacobperron jacobperron force-pushed the jacob/upstream_orocos_kdl branch from 6df4941 to 0114d09 Compare March 31, 2022 23:33
sloretz
sloretz reviewed Apr 1, 2022
View reviewed changes
@jacobperron
Depend on orocos_kdl_vendor
ebedf3c 
* Change package.xml dependency to the vendor package
* Add missing include directories for orocos_kdl
  Upstream should probably be updated to use modern cmake targets.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron force-pushed the jacob/upstream_orocos_kdl branch from 0114d09 to ebedf3c Compare April 1, 2022 20:42
@jacobperron
Disable mem-access warnings on aarch64
8d79ded 
Same as #506, but in a different file
where Eigen headers are being included.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Copy link
Copy Markdown
Member Author

jacobperron commented Apr 2, 2022

I had to add 8d79ded to quiet compiler warnings coming from Eigen headers.

@jacobperron
Copy link
Copy Markdown
Member Author

jacobperron commented Apr 4, 2022

@ros-pull-request-builder retest this please

@jacobperron jacobperron merged commit ea5b008 into ros2 Apr 4, 2022
@delete-merged-branch delete-merged-branch bot deleted the jacob/upstream_orocos_kdl branch April 4, 2022 23:56
@ijnek ijnek mentioned this pull request Apr 5, 2022
Closed
@henningkayser henningkayser mentioned this pull request May 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sloretz sloretz sloretz approved these changes

Assignees

@jacobperron jacobperron

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jacobperron @sloretz