Initialize the quaternion in the tf2_geometry_msgs unit tests#25
Merged
Conversation
clalancette
approved these changes
Jun 19, 2017
Contributor
clalancette
left a comment
There was a problem hiding this comment.
Oh yeah, absolutely. This has bitten me several times.
mikaelarguedas
approved these changes
Jun 19, 2017
Member
mikaelarguedas
left a comment
There was a problem hiding this comment.
lgtm, even if we dont do it by default (for performance reasons) we should consider providing a helper function giving zero initialized messages in C and C++...
Contributor
|
Honestly, I think we should discuss making the default zero-initialized, and providing a way to not do that for people who are really performance-conscious. This kind of problem is sneaky and hard to see, and is going to affect everyone developing on ROS2. |
Contributor
Author
|
@clalancette @mikaelarguedas good idea. ticketed ros2/ros2#367 |
11 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connects to #24