Improve readibility of reported thread ids in the multithreaded executor example#415
Merged
fujitatomoya merged 4 commits intoros2:rollingfrom May 11, 2025
Merged
Improve readibility of reported thread ids in the multithreaded executor example#415fujitatomoya merged 4 commits intoros2:rollingfrom
fujitatomoya merged 4 commits intoros2:rollingfrom
Conversation
Signed-off-by: jncfa <20467009+jncfa@users.noreply.github.com>
fujitatomoya
requested changes
May 10, 2025
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
@jncfa thanks for the PR.
a few cpplint and uncrustify warnings, can you address https://build.ros2.org/job/Rpr__examples__ubuntu_noble_amd64/34/testReport/
Signed-off-by: jncfa <20467009+jncfa@users.noreply.github.com>
fujitatomoya
approved these changes
May 10, 2025
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm with nit (i think CI will pick this up). i will start the CI.
rclcpp/executors/multithreaded_executor/multithreaded_executor.cpp
Outdated
Show resolved
Hide resolved
Collaborator
|
Pulls: #415
|
Signed-off-by: jncfa <20467009+jncfa@users.noreply.github.com>
Signed-off-by: jncfa <20467009+jncfa@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #413
Assigns an arbitrary index to each thread to make it easier to identify the threads in the log output on systems with many CPU cores.