Skip to content

Use target_link_libraries instead of ament_target_dependencies#404

Merged
ahcorde merged 4 commits intorollingfrom
sloretz__ament/ament_cmake#292_remove_ament_target_dependencies
Feb 10, 2025
Merged

Use target_link_libraries instead of ament_target_dependencies#404
ahcorde merged 4 commits intorollingfrom
sloretz__ament/ament_cmake#292_remove_ament_target_dependencies

Conversation

@sloretz
Copy link
Copy Markdown
Contributor

@sloretz sloretz commented Feb 7, 2025

ament_target_dependencies() hasn't been necessary for a while. This PR removes a bunch of uses of it.

ament/ament_cmake#292

Same branch name as:

Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
@sloretz sloretz self-assigned this Feb 7, 2025
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Feb 10, 2025

Pulls: #404
Gist: https://gist.githubusercontent.com/ahcorde/d395f2977e1531f5df431d9b46684b80/raw/fc985ccc44de9763bcd44b7dcc9af07c108c2ca0/ros2.repos
BUILD args: --packages-up-to examples_rclcpp_minimal_action_client examples_rclcpp_minimal_action_server examples_rclcpp_minimal_composition examples_rclcpp_cbg_executor examples_rclcpp_multithreaded_executor examples_rclcpp_async_client examples_rclcpp_minimal_client examples_rclcpp_minimal_service examples_rclcpp_minimal_timer examples_rclcpp_minimal_publisher examples_rclcpp_minimal_subscriber examples_rclcpp_wait_set --packages-above-and-dependencies examples_rclcpp_minimal_action_client examples_rclcpp_minimal_action_server examples_rclcpp_minimal_composition examples_rclcpp_cbg_executor examples_rclcpp_multithreaded_executor examples_rclcpp_async_client examples_rclcpp_minimal_client examples_rclcpp_minimal_service examples_rclcpp_minimal_timer examples_rclcpp_minimal_publisher examples_rclcpp_minimal_subscriber examples_rclcpp_wait_set
TEST args: --packages-select examples_rclcpp_minimal_action_client examples_rclcpp_minimal_action_server examples_rclcpp_minimal_composition examples_rclcpp_cbg_executor examples_rclcpp_multithreaded_executor examples_rclcpp_async_client examples_rclcpp_minimal_client examples_rclcpp_minimal_service examples_rclcpp_minimal_timer examples_rclcpp_minimal_publisher examples_rclcpp_minimal_subscriber examples_rclcpp_wait_set --packages-above examples_rclcpp_minimal_action_client examples_rclcpp_minimal_action_server examples_rclcpp_minimal_composition examples_rclcpp_cbg_executor examples_rclcpp_multithreaded_executor examples_rclcpp_async_client examples_rclcpp_minimal_client examples_rclcpp_minimal_service examples_rclcpp_minimal_timer examples_rclcpp_minimal_publisher examples_rclcpp_minimal_subscriber examples_rclcpp_wait_set
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15150

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 9ea5fee into rolling Feb 10, 2025
2 checks passed
@ahcorde ahcorde deleted the sloretz__ament/ament_cmake#292_remove_ament_target_dependencies branch February 10, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants