Message memory strategy example#39
Conversation
There was a problem hiding this comment.
I would recommend using size_t here.
|
+1 |
There was a problem hiding this comment.
These two statements could be simplified as:
auto msg_strategy_ptr = std::make_shared<SingleMessageMemoryStrategy<std_interfaces::msg::String>>();or
auto msg_strategy_ptr = SingleMessageMemoryStrategy<std_interfaces::msg::String>::SharedPtr(
new SingleMessageMemoryStrategy<std_interfaces::msg::String>());The current pair of statements are sort of wasteful since it expands to essentially this:
SingleMessageMemoryStrategy<std_interfaces::msg::String> msg_strategy;
SingleMessageMemoryStrategy<std_interfaces::msg::String>::SharedPtr msg_strategy_ptr(new SingleMessageMemoryStrategy<std_interfaces::msg::String>());
*msg_strategy_ptr = msg_strategy; // implicit copy|
I refactored the examples a bit to be in line with the changes in ros2/rclcpp#64. Most notably, I've added a |
a8850ae to
e0dca3f
Compare
|
@wjwwood, if these examples look OK to you, I'll merge it by the end of today. |
|
lgtm, +1 |
Message memory strategy example
|
@jacquelinekay With the windows build being back up again please revisit the new warnings introduced by this PR: http://ci.ros2.org/job/ros2_batch_ci_windows/133/warnings34Result/category.63476771/ |
Needs ros2/rclcpp#64