Remove use of get_callback_groups().#320
Merged
clalancette merged 1 commit intomasterfrom Jul 23, 2021
Merged
Conversation
This is not thread-safe, and we can do exactly the same thing by getting the default callback group and storing our custom callback group within the class. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
ivanpauno
approved these changes
Jul 23, 2021
Contributor
Author
|
CI for this is in #320 |
Contributor
|
@ralph-lange just fyi. Can you verify that the RT ping/pong behavior is still in tact here? |
Contributor
|
Thank you for pointing to this PR. Yes, the ping-pong demo works as before. I've already tested it on Saturday, while adding jitter measurement, cf. https://github.com/boschresearch/ros2_examples/tree/cbg_executor/jitter. |
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: |
jefferyyjhsu
pushed a commit
to jefferyyjhsu/ros2-examples
that referenced
this pull request
Apr 19, 2023
This is not thread-safe, and we can do exactly the same thing by getting the default callback group and storing our custom callback group within the class. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not thread-safe, and we can do exactly the same
thing by getting the default callback group and storing
our custom callback group within the class.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
Goes along with ros2/rclcpp#1723