fix ambiguous overloaded function call on Windows#18
Merged
Conversation
Member
Author
|
This is basically the patch @esteve proposed, I could not find a way to make it work without this... I tried |
Member
Author
|
For review. |
Member
|
LGTM |
Contributor
|
lgtm |
Member
|
+1, I have an idea of using std::enable_if and std::is_convertible, but I rather get this merged now and see if we can improve it later. |
Member
Author
|
Sounds good to me, Thanks. |
wjwwood
added a commit
that referenced
this pull request
Apr 29, 2015
fix ambiguous overloaded function call on Windows
Member
Author
|
I created an issue to track it: #20 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connects to ros2/rmw_connext#26