Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
|
Same question as on ros2/example_interfaces#10 |
|
In this case as the description of this set of packages mentioned Many user may copy-and-paste portions of this code in their project. I think that we need to assure in these packages that the quality of code is correct and provide them the right code from the very beginning. Feel free to close it if you consider that these changes are not adding any value. |
|
That is exactly my question: why should a user call the linters for the interfaces if they can't control the generated code anyway? |
|
I think adding linter checks to our examples is valid.
Perhaps there was a mix-up, but this PR is adding linters for hand-written code (not generated code). |
Signed-off-by: ahcorde <ahcorde@gmail.com>
|
friendly ping @jacobperron |
Signed-off-by: ahcorde <ahcorde@gmail.com>
* Added common linters Signed-off-by: ahcorde <ahcorde@gmail.com> * Added feedback Signed-off-by: ahcorde <ahcorde@gmail.com> * make linter happy Signed-off-by: ahcorde <ahcorde@gmail.com> Signed-off-by: Allison Thackston <allisoon@allisonthackston.com>
* Added common linters Signed-off-by: ahcorde <ahcorde@gmail.com> * Added feedback Signed-off-by: ahcorde <ahcorde@gmail.com> * make linter happy Signed-off-by: ahcorde <ahcorde@gmail.com> Signed-off-by: Allison Thackston <allisoon@allisonthackston.com>
* Added common linters Signed-off-by: ahcorde <ahcorde@gmail.com> * Added feedback Signed-off-by: ahcorde <ahcorde@gmail.com> * make linter happy Signed-off-by: ahcorde <ahcorde@gmail.com> Signed-off-by: Allison Thackston <allisoon@allisonthackston.com>
Added common linters
Signed-off-by: ahcorde ahcorde@gmail.com