Skip to content

Added common linters#265

Merged
ahcorde merged 4 commits intomasterfrom
ahcorde/test/common_linters
Jun 23, 2020
Merged

Added common linters#265
ahcorde merged 4 commits intomasterfrom
ahcorde/test/common_linters

Conversation

@ahcorde
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde commented Apr 20, 2020

Added common linters

Signed-off-by: ahcorde ahcorde@gmail.com

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added the enhancement New feature or request label Apr 20, 2020
@ahcorde ahcorde self-assigned this Apr 20, 2020
@dirk-thomas
Copy link
Copy Markdown
Member

dirk-thomas commented Apr 20, 2020

Same question as on ros2/example_interfaces#10

@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Apr 20, 2020

In this case as the description of this set of packages mentioned

This directory contains many examples of how to do common tasks with rclcpp.
The intent is that this material will be easy to copy-and-paste into your own projects.

Many user may copy-and-paste portions of this code in their project. I think that we need to assure in these packages that the quality of code is correct and provide them the right code from the very beginning.

Feel free to close it if you consider that these changes are not adding any value.

@dirk-thomas
Copy link
Copy Markdown
Member

That is exactly my question: why should a user call the linters for the interfaces if they can't control the generated code anyway?

@ahcorde ahcorde closed this May 11, 2020
@jacobperron
Copy link
Copy Markdown
Member

I think adding linter checks to our examples is valid.

why should a user call the linters for the interfaces if they can't control the generated code anyway?

Perhaps there was a mix-up, but this PR is adding linters for hand-written code (not generated code).

@jacobperron jacobperron reopened this Jun 10, 2020
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from jacobperron June 12, 2020 08:48
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Jun 19, 2020

friendly ping @jacobperron

Copy link
Copy Markdown
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahcorde ahcorde merged commit df1f37c into master Jun 23, 2020
@delete-merged-branch delete-merged-branch bot deleted the ahcorde/test/common_linters branch June 23, 2020 18:05
jacobperron pushed a commit that referenced this pull request Sep 8, 2020
* Added common linters

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* make linter happy

Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Allison Thackston <allisoon@allisonthackston.com>
jacobperron pushed a commit that referenced this pull request Sep 8, 2020
* Added common linters

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* make linter happy

Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Allison Thackston <allisoon@allisonthackston.com>
jacobperron pushed a commit that referenced this pull request Sep 8, 2020
* Added common linters

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* make linter happy

Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Allison Thackston <allisoon@allisonthackston.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants