Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
|
| rosidl_generate_interfaces(${PROJECT_NAME} | ||
| "action/Fibonacci.action" | ||
| "srv/AddTwoInts.srv" | ||
| ADD_LINTER_TESTS |
There was a problem hiding this comment.
Why should the example interfaces be linted? I don't think we want to recommend this usage to users.
There was a problem hiding this comment.
example_interfaces is being used in some packages (for testing) who aspire to be a Quality Level 1 packages. That's why I decided to add the linters.
Feel free to close it if you consider that this change is not adding any value.
There was a problem hiding this comment.
I don't see how the linters are relevant for any quality level?
There was a problem hiding this comment.
Linters are defined as part of the quality level of a package https://github.com/ros-infrastructure/rep/blob/e421be8db3ef6fa65b29f9325ce635afdaecbf16/rep-2004.rst#iii-a
without linters, a package could not be more than quality 3, does make sense to test code with Level 1 or Level 2 with poor quality level package?
There was a problem hiding this comment.
I am pretty sure the REP assumes linters for code the package actually writes. Maybe that needs to be clarified in the REP.
Added
ament_lint_commonSigned-off-by: ahcorde ahcorde@gmail.com