Merged
Conversation
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Member
|
The empy issue mentioned in #85 is now gone, but the GitHub job now fails just like the Rpr job. |
Contributor
Author
|
@christophebedard thanks for letting me know, i will take a look! |
Contributor
Author
|
i confirmed with local environment that ros2/rclcpp#2723 can fix the test failure happening in github workflow for rolling and rpr job. |
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
commented
Jan 9, 2025
Contributor
Author
|
@christophebedard all green 👍 |
christophebedard
approved these changes
Jan 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #85