Skip to content

Update subscription callback signatures#754

Merged
ahcorde merged 2 commits intoros2:rollingfrom
mini-1235:patch-1
Nov 11, 2025
Merged

Update subscription callback signatures#754
ahcorde merged 2 commits intoros2:rollingfrom
mini-1235:patch-1

Conversation

@mini-1235
Copy link
Copy Markdown
Contributor

@mini-1235 mini-1235 commented Nov 9, 2025

Description

Related to ros2/rclcpp#2975, ConstSharedPtr is preferred

Is this user-facing behavior change?

Did you use Generative AI?

No

Additional Information

@mini-1235
Update subscription callback signatures
76a1389 
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
@mini-1235
Copy link
Copy Markdown
Contributor Author

mini-1235 commented Nov 9, 2025

I will mark this as draft for now. There is another place in the demo that uses std::shared_ptr<rclcpp::SerializedMessage>, I will leave it to the maintainers to decide whether that should be updated as well

@mini-1235 mini-1235 marked this pull request as draft November 9, 2025 10:55
@mini-1235 mini-1235 mentioned this pull request Nov 9, 2025
Merged
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Nov 10, 2025

Pulls: #754
Gist: https://gist.githubusercontent.com/ahcorde/2cee3fb1a881e6b57e2b56907465fe5d/raw/4d79a703e850a25ae430c4d5014a26c181b7787e/ros2.repos
BUILD args: --packages-above-and-dependencies pendulum_control
TEST args: --packages-above pendulum_control
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17430

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Nov 10, 2025

I will mark this as draft for now. There is another place in the demo that uses std::shared_ptr<rclcpp::SerializedMessage>, I will leave it to the maintainers to decide whether that should be updated as well

please modify this other part too

@mini-1235
Update subscription callback signatures
f8c391e 
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
@mini-1235 mini-1235 marked this pull request as ready for review November 10, 2025 16:30
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Nov 10, 2025 •
edited
Loading

Pulls: #754
Gist: https://gist.githubusercontent.com/ahcorde/23ca4baee9d585741f3ec6c9c5d5ea7b/raw/4d79a703e850a25ae430c4d5014a26c181b7787e/ros2.repos
BUILD args: --packages-above-and-dependencies pendulum_control demo_nodes_cpp
TEST args: --packages-above pendulum_control demo_nodes_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17445

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 2e1c820 into ros2:rolling Nov 11, 2025
3 checks passed
@mini-1235 mini-1235 deleted the patch-1 branch November 11, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@ahcorde ahcorde ahcorde approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mini-1235 @ahcorde @mjcarroll @fujitatomoya