Skip to content

Add README's for action_tutorials.#576

Merged
audrow merged 13 commits intoros2:rollingfrom
kagibson:rolling
Dec 7, 2022
Merged

Add README's for action_tutorials.#576
audrow merged 13 commits intoros2:rollingfrom
kagibson:rolling

Conversation

@kagibson
Copy link
Copy Markdown
Contributor

Signed-off-by: Kurtis Gibson kurtisgibsonmusic@gmail.com

@kagibson kagibson mentioned this pull request Jul 26, 2022
@kagibson
Copy link
Copy Markdown
Contributor Author

@audrow

@audrow audrow self-requested a review July 27, 2022 17:21
Copy link
Copy Markdown
Member

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks good. I have a few formatting changes that should be applied throughout the READMEs.

@audrow audrow self-assigned this Jul 27, 2022
@kagibson kagibson force-pushed the rolling branch 4 times, most recently from 605f8db to f2b82e2 Compare July 27, 2022 19:17
@kagibson kagibson requested a review from audrow July 28, 2022 14:45
Copy link
Copy Markdown
Contributor Author

@kagibson kagibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made updates based on the changes you've requested. Thanks @audrow !

Copy link
Copy Markdown
Member

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good. There's a few small changes to be made.

@kagibson kagibson requested a review from audrow November 10, 2022 17:57
Copy link
Copy Markdown
Member

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the iteration @kagibson! I've given some feedback. It's looking better.

kagibson and others added 11 commits December 3, 2022 18:56
Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
Add Oxford comma

Co-authored-by: Audrow Nash <audrow@hey.com>
Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
Fix spacing on if statement

Co-authored-by: Audrow Nash <audrow@hey.com>
Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
Fix spacing on std::thread

Co-authored-by: Audrow Nash <audrow@hey.com>
Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
Add newlines

Co-authored-by: Audrow Nash <audrow@hey.com>
Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
@kagibson kagibson requested review from audrow and mjeronimo and removed request for adityapande-1995 and mjeronimo December 4, 2022 03:47
Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
Copy link
Copy Markdown

@mjeronimo mjeronimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Once Audrow is good, we can merge.

Copy link
Copy Markdown
Member

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thanks, @kagibson!

@audrow
Copy link
Copy Markdown
Member

audrow commented Dec 7, 2022

I'm going to merge this in without running CI since it only touches README files and the PR jobs are happy.

@audrow audrow merged commit c212741 into ros2:rolling Dec 7, 2022
cardboardcode pushed a commit to cardboardcode/demos that referenced this pull request Jan 23, 2023
Co-authored-by: Audrow Nash <audrow@hey.com>
cardboardcode pushed a commit to cardboardcode/demos that referenced this pull request Jan 23, 2023
Co-authored-by: Audrow Nash <audrow@hey.com>
Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants