Merged
Conversation
sloretz
reviewed
Dec 13, 2018
lifecycle/README.rst
Outdated
| * ``rclcpp_lifecycle::node_interfaces::LifecycleNodeInterface::CallbackReturn | ||
| on_cleanup(const rclcpp_lifecycle::State & previous_state)`` | ||
| * ``rclcpp_lifecycle::node_interfaces::LifecycleNodeInterface::CallbackReturn | ||
| on_shutdown(const rclcpp_lifecycle::State & previous_state)`` |
Contributor
There was a problem hiding this comment.
The functions look a bit weird on github's preview, but the bouncy version looks fine https://github.com/ros2/demos/blob/bouncy/lifecycle/README.rst
Contributor
Author
There was a problem hiding this comment.
should be addressed now
90fd38a to
e6fec40
Compare
e6fec40 to
a6038ad
Compare
sloretz
reviewed
Jan 3, 2019
lifecycle/README.rst
Outdated
| .. code-block:: bash | ||
|
|
||
| [lc_listener] notify callback: Transition from state unconfigured to configuring | ||
| [lc_listener] notify callback: Transition from state configuring to inactive |
Contributor
There was a problem hiding this comment.
I see two more transitions after these before the listener receives data
[INFO] [lc_listener]: notify callback: Transition from state inactive to activating
[INFO] [lc_listener]: notify callback: Transition from state activating to active
Contributor
Author
There was a problem hiding this comment.
good catch. That was a copy paste error.
sloretz
approved these changes
Jan 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is referring to ros2/ros2_documentation#47 (comment)
The documentation of the lifecycle (in fact every demo) should be contained within the package and not duplicated in the
ros2_documentationpackage.