Replace python script with ros2 lifecycle#47
Merged
Conversation
Change section from using lifecycle_service_client_py.py to use ros2 lifecycle lifecycle_service_client_py.py was removed in ros2/demos#283
dirk-thomas
approved these changes
Dec 12, 2018
| ^^^^^^^^^^^^^^ | ||
|
|
||
| The ``lifecycle_service_client`` application is a fixed order script for this demo purpose only. It explains the use and the API calls made for this lifecycle implementation, but may be inconvenient to use otherwise. For this reason, we implemented a separate python script, which lets you dynamically change states or various nodes. | ||
| The ``lifecycle_service_client`` application is a fixed order script for this demo purpose only. It explains the use and the API calls made for this lifecycle implementation, but may be inconvenient to use otherwise. For this reason we implemented a command line tool which lets you dynamically change states or various nodes. |
Member
There was a problem hiding this comment.
Good example why every sentence should start on a new line. That should probably addressed separately though.
Contributor
|
I actually think this page should be removed completely. The official documentation for the lifecycle was actually shifted to https://index.ros.org/p/lifecycle/github-ros2-demos/#bouncy and the top-level entry point within the tutorials page should directly to the ros-index. In the package readme.md is also the concern of one sentence per line addressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change section from using lifecycle_service_client_py.py to use ros2 lifecycle
lifecycle_service_client_py.py was removed in ros2/demos#283
Also the lifecycle services no longer accept a
node_nameargument.