Skip to content

Strip formatting from console output for output matching#189

Merged
dhood merged 3 commits intomasterfrom
strip_console_formatting
Nov 20, 2017
Merged

Strip formatting from console output for output matching#189
dhood merged 3 commits intomasterfrom
strip_console_formatting

Conversation

@dhood
Copy link
Copy Markdown
Member

@dhood dhood commented Nov 14, 2017

This is preparation for swapping demos to logging macros. I don't mind if we merge this now or later but I want to kick off the review process in case there are any hiccups.

29e3716 is included to show that the change does what's expected, it's not being proposed for merge and will be removed before merge.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@dhood dhood added the in review Waiting for review (Kanban column) label Nov 14, 2017
@dhood dhood self-assigned this Nov 14, 2017
Copy link
Copy Markdown
Contributor

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dhood dhood added in progress Actively being worked on (Kanban column) and removed in review Waiting for review (Kanban column) labels Nov 15, 2017
@dhood
Copy link
Copy Markdown
Member Author

dhood commented Nov 20, 2017

merging now that the functionality is exercised by #191

@dhood dhood merged commit 5411e7e into master Nov 20, 2017
@dhood dhood deleted the strip_console_formatting branch November 20, 2017 22:39
@dhood dhood removed the in progress Actively being worked on (Kanban column) label Nov 20, 2017
@dirk-thomas
Copy link
Copy Markdown
Member

These setup() function aren't used when the generated Python file is being invoked directly (using __main__). Removed as part of #225.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants